Added support for Redis v2.8.x.

bennojoy / redis

ansible role for configuring redid

12 stars 22 forks source link

Open tjanez opened 9 years ago

tjanez commented 9 years ago

Ansible checks if the version of Redis is 2.8.x and uses a different configuration template if it is.

bennojoy commented 9 years ago

Hi ,

Could you please split the task into two , eventhough the below is a valid jinja, we dont encourage usning conditionals within the {{ }}.

name: Copy the Redis configuration file
template: src={{ "redis-2.8.conf.j2" if redis_version.stdout | search("v=2.8") else "redis.conf.j2" }} dest={{ redis_conf_dest }}

so the task woudl have

template: src=redis-2.8.conf.j2 when:redis_version.stdout | search("v=2.8")

Similarly for the other pr also please.

tjanez commented 9 years ago

Sure, no problem. I'll update both PRs.

tjanez commented 9 years ago

@bennojoy, I updated the PR. Please, review.

tjanez commented 9 years ago

@bennojoy, ping?