search

bennomeier / leCroyParser

A Python Module to parse LeCroy Binary Trace Files
MIT License
12 stars 8 forks source link

Update readme, Fix for #6 #8

Closed JeroenvO closed 3 years ago

JeroenvO commented 3 years ago

Closes #4

JeroenvO commented 3 years ago

From a simple timeit test, it looks like it gets about 25% faster by this update.

bennomeier commented 3 years ago

Thanks for this. Is there a particular reason why you removed the comment about sparse parsing from the Readme? For me this is a rather useful feature.

Did you test whether the modifed code is still compatible with Python 2.7?

JeroenvO commented 3 years ago

Hi, Thanks for the quick response!

Sparse is still there, i just inserted the part for data processing. Maybe it is useful to add some more headers to the readme for readability.

Good remark on python2 compatibility, i forgot about that. I just tested python2 and it still works (tested python 2.7.18 with numpy 1.16.6 and python 3.8.6 with numpy 1.19.4)

I can add the testing scripts if as well if you like.