search

bennord / appstore-tools

Tools for interacting with the AppStore Connect api
MIT License
1 stars 1 forks source link

Prevent .DS_Store files from being uploaded #8

Closed luke14free closed 1 year ago

luke14free commented 3 years ago

on mac osx you will typically have .DS_Store files automatically generated by finder. It would probably be better to prevent their upload

      /.../sv/previews/IPHONE_65/.DS_Store - uploading chunk (offset: 0, length: 6148)
      .DS_Store - commiting upload
bennord commented 3 years ago

Hmm, this is a good point. Probably should have a white/black list of files for the screenshots and previews folders.

luke14free commented 3 years ago

yup! although nowadays they are called allow_list and disallow_list 💀

could be as simple as accepting only:

'jpg','jpeg','png','mp4','mov','avi'
bennord commented 3 years ago

It's easier for maintainability if we allow as broad a range of image/video files as possible, so it's not a list that needs to be updated whenever apple changes the supported types.

bennord commented 1 year ago

@luke14free : It's been a while, but recently I came back to this as I was setting up another IOS project.

Not sure if you are still using this tool, but if so, I've added a new flag --asset-ignore that should resolve this issue for you now. https://github.com/bennord/appstore-tools/pull/13

Cheers!