search

bennord / appstore-tools

Tools for interacting with the AppStore Connect api
MIT License
1 stars 1 forks source link

Add support for preview frame time code #9

Closed luke14free closed 1 year ago

luke14free commented 3 years ago

This PR introduces two features:

(1) validation of the uploaded app previews and removal of "FAILED" uploaded assets (thus preventing things such as those describe in #7 to happen in the frontend) (2) setting of the preview time code to either: 00:00:00:01 or the value of the <preview_name_without_extension>.txt. Note that this is an opinionated choice, as the app store by default uses the value at 00:00:05:01 which to me is quite non-sensical (#4)

luke14free commented 3 years ago

I have also added an allow list for videos which is mp4, mov, avi (nothing else should be supported by App Store Connect)

luke14free commented 3 years ago

And ".jpg", ".jpeg", ".png", ".tif", ".tiff", ".bmp" for images (I know it's outside of the scope once again.. sorry)

bennord commented 3 years ago

Just fyi, on holiday for a week, so I'll be a bit slow to respond. I'll take a look at the PRs soon as I get back.

luke14free commented 3 years ago

oh no worries!! enjoy! :D

bennord commented 1 year ago

https://github.com/bennord/appstore-tools/pull/16 addresses the previewFrameTimeCode feature. Thanks for the feature idea/investigation!

bennord commented 1 year ago

Let me know if there's anything missing still from this PR that hasn't been addressed and we can reopen something if needed.