Closed chenrui333 closed 1 week ago
Thanks for the report. I'm afraid I can't reproduce this. I don't have access to a macOS machine, but the linked Homebrew PR includes brew test --verbose literate-git
failed on Linux!, so I installed Homebrew on my Linux machine. Checking out the brew-pip-audit-literate-git-1721126744
branch of homebrew-core
, I could install successfully. Then brew test literate-git
failed because git couldn't find my user.name or user.email. I added lines to the test do
section of the formula to configure these, then brew test literate-git
ran successfully.
Couple of other things:
The backtrace is confusing.
jinja2.exceptions.UndefinedError: 'literategit.LeafCommit object' has no attribute 'diff'
is odd because LeafCommit
derives from Node
, which defines a diff
property.
The only change from 0.4.7 to 0.4.8 is to use a newer setuptools, and I don't see how this would be relevant to the error you're seeing.
The CI on GitHub passed for all macos-latest
configurations.
Any ideas welcome!
The exception is misleading, the issue is pygit2==1.15.0
made several breaking changes (including renaming oid
to id
): https://github.com/libgit2/pygit2/blob/master/CHANGELOG.md#1150-2024-05-18
Thanks, @branchvincent, for the pointer. I've now updated the dependency to pygit2 1.15.1
, and fixed the handful of places in the code relating to those breaking changes. I've published literategit-0.5.0
, which hopefully will build under Homebrew too.
Thank you @bennorth! Confirmed everything looks good on the homebrew side with https://github.com/Homebrew/homebrew-core/pull/181390
Thanks for confirming!
👋 seeing some runtime failure while building literategit 0.4.8
relates to https://github.com/Homebrew/homebrew-core/pull/177485