bennyLCK / pe

0 stars 0 forks source link

Incorrect message given when `addappt` command was supplied with an invalid date #7

Open bennyLCK opened 5 months ago

bennyLCK commented 5 months ago

Running the addappt 1 d/30/2/2024 3pm-4pm command shows the below error message.

image.png

Since 30 Feb never exists, when supplied with such a date given any year, I would expect the error message "invalid date supplied" error message. Again, without an accurate error message, whenever a user say in this case mistypes the month as 2 instead of 12, he would not be able to quickly figure what went wrong, hence causing inconvenience that is not clearly addressed in the UG.

soc-se-bot commented 4 months ago

Team's Response

There are two wrong things with this command: the first is the fact that the date is not written in dd/MM/yyyy format, which is being picked up by the parser, resulting in that specific error message being thrown. This is the intended error message: trying this with addappt 1 d/30/02/2024 3pm-4pm will give you your desired error message.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]