bennyLCK / pe

0 stars 0 forks source link

Allowing part matches of names for `Find` command may lower usefulness of searches #9

Open bennyLCK opened 6 months ago

bennyLCK commented 6 months ago

Although part name matches were mentioned in the UG:

image.png

Searches like "rick" may include search results of people: "ricky", "patrick", "merrick" even if the user specifically only wants rick as a name.

soc-se-bot commented 6 months ago

Team's Response

That is why we allow you to search by other fields such as phone number as well. Allowing partial matches is an intended feature to help clinic clerks find patients with greater ease (consider a patient named Izz ‘Akil, a clinic clerk may be hard-pressed to spell his name and searching “Izz” would be much easier. Izz was a real person in my unit in NS, his name is just hard to spell correctly).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The original AB3 implementation of the find command assured word matches which may have come with the feature flaw that it makes it near impossible to search for someone with a very lengthy name using partial name words matching. In the case of a partial name search, the feature flaw that I mentioned is also relevant as it makes it mandatory for all persons whose name partially match the keyword (although not wanted or needed) to be displayed in the output. Although I agree partial name searching does have its benefits which cover previous AB3's limitations, it also introduces possible flaws that needs to be addressed.

In terms of the alternatives mentioned, allowing us to find according to phone numbers or even address, although it may allow users who want to have a workaround finding someone with a common name, it has its issues and in certain occasions may even be unusable to the user. For example, if a user decides that the part thereof of a person's name is too common to many names in the database and instead decides to search by his phone number or address, he may not be able to do so since clinic clerks are seldom able to remember many patients' contact information if even at all. Another possible complication is, since the user is unable to specify if he is searching for phone number or address in particular, extra entries may be displayed to the user (e.g. user only remembers first 3 digits of the phone number (638) of a patient and tries to search for the patient, but additional entries of people with phone numbers including (638) anywhere in their phone numbers or even addresses, as in their postal code are also shown).