Add ability to generate wallet addresses

bennycode / coinbase-pro-node

Coinbase API written in TypeScript and covered by tests.

https://bennycode.com/coinbase-pro-node

MIT License

254 stars 62 forks source link

Add ability to generate wallet addresses #727

Closed jonluca closed 2 years ago

jonluca commented 2 years ago

The official docs have an endpoint to generate a deposit address for an account, by POSTing to:

https://api.exchange.coinbase.com/coinbase-accounts/{account_id}/addresses

I don't believe the library currently has this functionality, it would be nice to have added

bennycode commented 2 years ago

Hi @jonluca and thank you very much for your great contribution (#728). I merged your code and updated some URLs from "pro.coinbase.com" to "exchange.coinbase.com". I consider this URL update a breaking change which is why there is coinbase-pro-node v5.0.0 now. It includes the ability to generate wallet addresses. 🎉

jonluca commented 2 years ago

Nice! I agree re: breaking change. It's probably safe but it's the kind of change that might be an issue for some using the package. Thanks for ther fast response and update!