bennyguitar / libHN

The definitive Objective-C library for adding HackerNews to your iOS/Mac app.
MIT License
150 stars 26 forks source link

HUGE leaks when using cocoapods #9

Closed wokalski closed 10 years ago

wokalski commented 10 years ago

You ought to set s.requires_arc = true in the podspec. There are also a few minor leaks (at least in HNWebService).

bennyguitar commented 10 years ago

You should open a pull-request based on the changes you made in your fork.

wokalski commented 10 years ago

I don't think so. In the podspec I changed the homepage and authors, too. Just add requires_arc = true in your podspec.

Dimillian commented 10 years ago

Why is this not merged, this project use ARC, so yes, it should include this flag.

Dimillian commented 10 years ago

Ref: http://guides.cocoapods.org/syntax/podspec.html#requires_arc

Dimillian commented 10 years ago

Proof screen shot 2014-07-10 at 18 24 53

Each time I would refresh the feed, it would leak a bit of data, just merge the pull request, and done :) At the moment it run in ARC free mode.

bennyguitar commented 10 years ago

This has been done. Thanks for taking the time to figure it all out and post about it.

Dimillian commented 10 years ago

Well, I forked it and tried it live, it still leak, a lot of less, but still :) It's about retain cycle with block I think, it's not big, but it worth investigating if you want.

wokalski commented 10 years ago

Check out my fork. I fixed it.

bennyguitar commented 10 years ago

Still confused why you didn't pull request that @wczekalski haha. I'll try to go through this weekend and make fixes. I've got some ideas for new things in here now too.

Dimillian commented 10 years ago

Awesome, can you send a pull request then ?

wokalski commented 10 years ago

I think I’ve made some application-specific changes.

bennyguitar commented 10 years ago

Haha, so this weekend then, you can expect some changes. Unless you want to tackle it @Dimillian

Dimillian commented 10 years ago

Okay, so someone will need to extract only the fixes from your code. I'll take a look too.