Closed wokalski closed 10 years ago
You should open a pull-request based on the changes you made in your fork.
I don't think so. In the podspec I changed the homepage and authors, too. Just add requires_arc = true
in your podspec.
Why is this not merged, this project use ARC, so yes, it should include this flag.
Proof
Each time I would refresh the feed, it would leak a bit of data, just merge the pull request, and done :) At the moment it run in ARC free mode.
This has been done. Thanks for taking the time to figure it all out and post about it.
Well, I forked it and tried it live, it still leak, a lot of less, but still :) It's about retain cycle with block I think, it's not big, but it worth investigating if you want.
Check out my fork. I fixed it.
Still confused why you didn't pull request that @wczekalski haha. I'll try to go through this weekend and make fixes. I've got some ideas for new things in here now too.
Awesome, can you send a pull request then ?
I think I’ve made some application-specific changes.
Haha, so this weekend then, you can expect some changes. Unless you want to tackle it @Dimillian
Okay, so someone will need to extract only the fixes from your code. I'll take a look too.
You ought to set
s.requires_arc = true
in the podspec. There are also a few minor leaks (at least in HNWebService).