bennyguo / instant-nsr-pl

Neural Surface reconstruction based on Instant-NGP. Efficient and customizable boilerplate for your research projects. Train NeuS in 10min!
MIT License
856 stars 84 forks source link

Origin of magic constants within code #42

Closed kzhang2 closed 1 year ago

kzhang2 commented 1 year ago

Hi, Where does 1.732 2 come from from the below line? https://github.com/bennyguo/instant-nsr-pl/blob/6ab0c3d7e1db4973372b726a517d02bef6c8cf2a/models/neus.py#L58 I'm guessing that this is sqrt(3) 2, but how was it derived?

bennyguo commented 1 year ago

Hi! This simply calculated the step size as 1 / self.config.num_samples_per_ray of the diagonal length of the bounding box :)

kzhang2 commented 1 year ago

thanks!