bennyguo / nerfren

Code release for NeRFReN: Neural Radiance Fields with Reflections (CVPR 2022).
134 stars 10 forks source link

Reflection masks not being applied #8

Closed JeremiahJiangJ closed 1 year ago

JeremiahJiangJ commented 1 year ago

I created 4 reflection masks but it doesn't seem like the masks are doing anything during training as there are no reflected regions in the images in checkpoints/vis. I used photoshop to create the masks by selecting the mirror in the image and creating a fill layer from it. I also applied --with_mask and specified --num_masks 4.

Is there something else I need to look out for?

bennyguo commented 1 year ago

Hi! How many training images did you use? Could you try to label more masks or raise lambda_beta_mask to see if it works?

JeremiahJiangJ commented 1 year ago

Thanks for the reply and suggestions! I used 20 training images.

bennyguo commented 1 year ago

20 seems a reasonable amount. By the way, remember not to label the mirror frame as part of the reflection mask. It’s a strong cue about the depth of the mirror and should not be forced as a reflection area.

JeremiahJiangJ commented 1 year ago

Ok noted!