search

bennyhat / protractor-istanbul-plugin

Protractor plugin that collects istanbul coverage results from a page and dumps them to coverage.json files (one per spec).
MIT License
15 stars 7 forks source link

fix(plugin): Fix the plugin options config #3

Open thaiat opened 9 years ago

thaiat commented 9 years ago

FIxes #2

bennyhat commented 9 years ago

Hey Avi, Thanks for looking into this. I have merged your change into a bugfix branch - https://github.com/bennyhat/protractor-istanbul-plugin/tree/bugfix/protractor-2.2-updates, which I'll publish to NPM as version 2.0.0 in a moment and let you know (skipping 1.0.0 as I screwed up my versioning early on). I will hopefully merge this into the master branch once I fix all of the unit tests to reflect your change. Unfortunately, I'm pretty sure that protractor 2.2 broke a few more things than just this, as they changed a lot of the function definitions (moving function references into the first arg for most of the hooks, for example). Thanks! Ben

bennyhat commented 9 years ago

All right - v2.0.0 is out on NPM for your immediate use. However, like I mentioned, it will not be merged into master until I get those units tests updated (and probably add some integration tests for protractor 2.2 as well). Thanks! Ben

thaiat commented 9 years ago

thks @bennyhat from what i can tell i have been using your plugin on a very large app with protractor 2.2 and everything is ok