search

bennyhodl / dlcdevkit

application tooling for dlc's 🌊
https://dlcdevkit.com
MIT License
18 stars 6 forks source link

paths to dependencies in Cargo.toml reflect setup on local machine #14

Open ramin opened 2 months ago

ramin commented 2 months ago

When setting this up to see if i could make a contribution, i noticed a few entries in ddk/Cargo.toml reference local dependencies https://github.com/bennyhodl/dlcdevkit/blob/master/ddk/Cargo.toml#L19

eg:

dlc = { version = "0.6.0", path = "/Users/ben/ernest/dev/libs/rust-dlc/master/dlc", features = ["use-serde"] }
dlc-manager = { version = "0.6.0", path = "/Users/ben/ernest/dev/libs/rust-dlc/master/dlc-manager", features = ["use-serde"] }
dlc-messages = { version = "0.6.0", path = "/Users/ben/ernest/dev/libs/rust-dlc/master/dlc-messages", features = [ "use-serde"] }
dlc-trie = { version = "0.6.0", path = "/Users/ben/ernest/dev/libs/rust-dlc/master/dlc-trie", features = ["use-serde"] }

I'd like to propose we create a .gitignored directory in the project (libs) that has said dependies referenced and we update the Justfile to pull these from the proper git sha (i assume 0.6.0 of these is a pre-release?)

Then we can replicate this setup in a CI step i was planning to build?

Thoughts?

EvanWinget commented 2 months ago

I'm supportive of moving these to gitignore and pulling down via Just - same pattern is seen in /payouts/cargo.toml and in mprocs.yaml

I've been playing around trying to get a local example running and haven't been able to do it successfully yet

bennyhodl commented 2 months ago

I'd like to propose we create a .gitignored directory in the project (libs) that has said dependies referenced and we update the Justfile to pull these from the proper git sha (i assume 0.6.0 of these is a pre-release?)

That's a great I idea.

Ya, making a big upgrade for bitcoin@32.0 pr here to rust-dlc

bennyhodl commented 2 months ago

I pushed git links to my PR's for bitcoin:0.32.2

Should be able to build now until 32 is merged to kormir and rust-dlc