search

bennyhodl / dlcdevkit

application tooling for dlc's 🌊
https://dlcdevkit.com
MIT License
18 stars 6 forks source link

The oracle client implementation doesn't support numeric events #22

Open rorp opened 2 months ago

rorp commented 2 months ago

It supports only enum events for some reason.

bennyhodl commented 2 months ago

The P2P Derivatives oracle implementation does support numerical. I opted for the kormir client because it is more flexible with attestations in a testing environment.

I created https://github.com/bennyhodl/dlcdevkit/issues/23 to allow numerical contracts in ddk-node

A part of the opensats grant is implementing numerical contracts with kormir. No timetable set for that implementation. But it will be supported in the future.

rorp commented 2 months ago

A part of the opensats grant is implementing numerical contracts with kormir.

Interesting, can I have a part of the grant since I already implemented numeric events for kormir: https://github.com/benthecarman/kormir/pull/6? :)

rorp commented 2 months ago

Last change in the P2P Derivatives oracle repo was 2 years ago, and it's not general purpose oracle - it's closely coupled with the data feed.

Kormir seems more suitable for a development kit, since it's pretty flexible and can be used for any type of DLC application.

Also, maybe it makes sense to support the bitcoin-s oracle? The repo is still active and bitcoin-s itself is the reference implementation of DLC protocol.

bennyhodl commented 1 month ago

Nice! Beat me to it.

I'm with you on P2P, it was easy to pick off the shelf when I first started the project being able in rust-dlc and then I started migrating to kormir.

I'm with you on bitcoin-s. Would you be open to pick it up?

bennyhodl commented 1 month ago

Created a tracking issue https://github.com/bennyhodl/dlcdevkit/issues/32