search

bennylope / django-organizations

:couple: Multi-user accounts for Django projects
http://django-organizations.readthedocs.org/
BSD 2-Clause "Simplified" License
1.31k stars 212 forks source link

Make all default `send_*` funcs return result of `<message_class>.send()` #277

Closed mgrdcm closed 5 months ago

mgrdcm commented 5 months ago

Right now 2 implicitly return this already, and 2 explicitly only return True if it gets that far.

This is technically a breaking change, though as far as I can tell the return values of those functions aren't documented right now so...

Note that the modeled.ModelInvitation's version already does exactly this explicitly.

(note was originally gonna unify these like https://github.com/bennylope/django-organizations/pull/276 but this is just as half-backwards-compatible and also exposes more useful information)

bennylope commented 5 months ago

Good idea!