search

bennylope / pygeocodio

:globe_with_meridians: A Python wrapper for the Geocodio geolocation service API
BSD 3-Clause "New" or "Revised" License
94 stars 21 forks source link

Custom Endpoint #62

Open Statsguy808 opened 3 weeks ago

Statsguy808 commented 3 weeks ago

Are there any plans to add an option for custom Endpoints when connecting, so that we can leverage hipaa compliant datasets?

bennylope commented 3 weeks ago

No plans, but would welcome a proposal or just a little bit more info about what this actually means in practice.

Statsguy808 commented 3 weeks ago

Sure, this would be allowing the entering of either a custom base url rather than 'https://API.geocod.io/v{api_version}'. There are instances where companies have their own base url API and also instances where you would want to hit the HIPAA compliant base url ('https://api-hipaa.geocod.io/v{api_version'). Let me know if that makes sense. Edit: whoops see HIPAA enabled code on here but no custom.

bennylope commented 3 weeks ago

Documentation is the problem here!

The client already supports both custom endpoints and the HIPPA compliant endpoint.

https://github.com/bennylope/pygeocodio/blob/077a486ff66da9ea7ab85652f91c3dedb45ae559/src/geocodio/client.py#L62-L70

Statsguy808 commented 3 weeks ago

Oh great, thanks!