search

bennymeg / Fabrication-Toolkit

An JLC PCB Fabrication Plugin for KiCad
Apache License 2.0
300 stars 52 forks source link

Don't change output folder and store backups as zip #110

Closed dzid26 closed 6 months ago

dzid26 commented 8 months ago

Store backups as zip instead of new directories. This makes it easier when uploading files in the browser, so that we don't have to keep switching folders and finding were latest production files are. Zips are still stored with a timestamp in backups subfolder.

Also fixes orphaned temporary folders in system temp directory. The timestamp in temp folders was probably added for debugging, but original temp folder was never removed. Fixed by removing the timestamp from temp folders.

SmittyHalibut commented 7 months ago

I came here to request that the output folders not change with every export, but I like this solution better (still keeping multiple copies, but zipped, and keeping the current output in a consistent folder.)

Is there not an up-vote for PRs? :-)

I'm not an expert on this code base, but I looked over your commits and it all looked reasonable (and cleaned up a bit) to me.