Single offset for a given footprint will be applied correctly to all footprint (with different rotations and board side).
No more --mixed values-- depending on top/bottom PCB placement. Fixes #101.
Following example.zip contains some extra offsets added to footprints.
Top/bottom without this PR:
Top/bottom with the PR:
Notes:
USB-C and diodes have artificial offset added to the footprint. Notice that top diodes offsets are the same after PR. However USB-C position offset has changed after PR. This is because position offset should be applied without rotation offset (it depends only on footprint orientation and not final part orientation). And, unlike diodes, USB-C has a rotation offset.
QFN and DFN chips and diodes are only correct on both side of the board with the PR
SOT23 transistors are correct even before the PR, because 180deg correction accidentally worked on both sides the same
if one wants to replicate this example, ignore J5, J6 for now, they are centered correctly for me because I am modified anchor calculation locally for now
Single offset for a given footprint will be applied correctly to all footprint (with different rotations and board side).
No more
--mixed values--
depending on top/bottom PCB placement. Fixes #101.Following example.zip contains some extra offsets added to footprints.
Top/bottom without this PR:![](https://github.com/bennymeg/JLC-Plugin-for-KiCad/assets/841061/f6cdb59b-d96a-49ec-94bc-29c737e237ca)
Top/bottom with the PR:
![](https://github.com/bennymeg/JLC-Plugin-for-KiCad/assets/841061/0ca0d8a4-0513-49cd-92b7-d7fca2c9f07e)
![](https://github.com/bennymeg/JLC-Plugin-for-KiCad/assets/841061/945dc8f6-502b-4ef1-ae1e-41b4e7cbb18f)
Notes: