bennymeg / Fabrication-Toolkit

An JLC PCB Fabrication Plugin for KiCad
Apache License 2.0
280 stars 49 forks source link

User layers being exported into edge cuts gerber #149

Closed partlyhuman closed 2 months ago

partlyhuman commented 3 months ago

Hello!

Informational graphics from my User.1 layer are being exported into the edge cuts gerber when using the fabrication toolkit, causing an error in fabrication(!) I'm not sure how to change this behaivour. In the board stackup, User.1 is defined as a "User defined layer". This issue doesn't occur when using export gerbers normally. Archive.zip

flash-32mbit-Edge_Cuts.gbr generated by plugin:

Screenshot 2024-04-05 at 12 32 27 PM

flash-32mbit-Edge_Cuts.gbr generated by export:

Screenshot 2024-04-05 at 12 33 28 PM

User.1 layer in schematic:

Screenshot 2024-04-05 at 12 33 58 PM

From: https://github.com/partlyhuman/loopycart/tree/main/pcb/flash-32mbit Note I haven't pushed the change, but this user layer was called "User.FrontReference". I renamed it to "User.1" hoping that this would fix the issue, but it did not.

Please let me know if I can provide more information. Thank you!

bennymeg commented 3 months ago

This feature was requested by the community in order to allow adding additional data for i.e. edge cuts.

partlyhuman commented 3 months ago

This feature was requested by the community in order to allow adding additional data for i.e. edge cuts.

I can only say that while some people may desire it, I can also see others having their designs ruined in fabrication if they don't carefully check the exported gerbers, if they have the naive expectation that only edge cuts are exported into edge cuts. If it's extra functionality, I believe it would be best to opt-in to it using some sort of preference in the plugin. But that's just my 2c.

Can you explain a little how it's determined which extra graphics are exported into which layer, so I can avoid this happening unintentionally?

bennymeg commented 3 months ago

only the User.1 is combined with the edge cut layer for penalization and such. You are right, I will add an option for this feature. In your experience, which layer is commonly used for this use.

partlyhuman commented 2 months ago

Thank you!!!