bennymeg / Fabrication-Toolkit

An JLC PCB Fabrication Plugin for KiCad
Apache License 2.0
322 stars 57 forks source link

Plot options not setting "substract soldermask from silkscreen" #29

Closed kiu closed 1 year ago

kiu commented 1 year ago

So far I manually created my gerber files for JLC based on this: https://support.jlcpcb.com/article/194-how-to-generate-gerber-and-drill-files-in-kicad-6

JLC recommends to enable "Substract soldermask from silkscreen" which I sometimes rely on due to "background art" bleeding into pads.

Is there a reason why you are not setting this?

https://github.com/bennymeg/JLC-Plugin-for-KiCad/blob/master/plugins/process.py#L32 plot_options.SetSubtractMaskFromSilk(False)

bennymeg commented 1 year ago

They probably updated their recommendation. I will fix it in the next release (you can submit a PR if you wish =]). Thanks for letting me know.