search

bennymeg / Fabrication-Toolkit

An JLC PCB Fabrication Plugin for KiCad
Apache License 2.0
307 stars 53 forks source link

JLC Rotation Offset different on back of PCB #33

Closed revk closed 1 year ago

revk commented 1 year ago

I don't know if JLCPCB do something unusual here, but I have parts with an JLC Rotation offset which work correctly on the front of the PCB but wrong on the back. E.g. one that needed +90 on front needed -90 on back, and similarly one was 0 and 180. Does the rotation offset need adjusting when used on back of board?

As I am including the JLC Rotation Offset in my parts template it would help if I did not have to adjust this per side.

By the way, this is an awesome and useful plugin. Well done.

bennymeg commented 1 year ago

I do not know. But since you give an offset per part, why does that matter? I can add 180° to the offset of parts that are on the bottom side, but wouldn't it be confusing?

revk commented 1 year ago

Well it means I cannot simply have the necessary offset defined in the parts library for the part and the way JCLPCB work with that part number. I have to manually change a part depending on which side of the board it is placed. Some parts are obvious but some (like diodes or SO-6) are far from it. What is "confusing" is I cannot make a part in the part library, get it right, and just use it.

bennymeg commented 1 year ago

I meant it would be confusing for user if so of the offset they defined will be altered. I understand the issue, but I do not have an idea how to solve it properly.

revk commented 1 year ago

Fair point.

Maybe a differently named offset setting that does this to match how JLC do it, which is the new setting, with the old one deprecated but retained for backward compatibility.

revk commented 1 year ago

Closing, this is not a rotation offset issue, so would not be fixed by a new keyword, raised separate issue for this.