bennymeg / Fabrication-Toolkit

An JLC PCB Fabrication Plugin for KiCad
Apache License 2.0
322 stars 57 forks source link

BOM lines with similar values are merged even if they're completely different parts #45

Closed alexisvl closed 1 year ago

alexisvl commented 1 year ago

I'm not sure I understand the purpose of #38 / #36. It results in some ill advised merges. I have a project with some 10µF 0805 capacitors and some 10µH 0805 inductors. The capacitors have a JLC part number specified, but the inductors don't (I'm skipping those parts). This plugin merges them together into a single BOM line:

"C104,C111,C142,C162,C172,C304,C311,C342,C362,C372,L101,L102,L301,L302",0805,14,10µ,C440198

Merging lines for totally different types of parts doesn't seem like a good idea. At very least, parts with different JLC/LCSC part number fields (including no field at all) probably shouldn't be merged...