search

bennymeg / Fabrication-Toolkit

An JLC PCB Fabrication Plugin for KiCad
Apache License 2.0
300 stars 52 forks source link

Error in PCB editor when clicking fabrication #81

Closed SharkiBoom closed 11 months ago

SharkiBoom commented 1 year ago

ERROR in method 'BOARD_DESIGN_SETTINGS_m_SolderMaskMargin_set', argument 2 of type 'int'

I'm not sure how to fix this and I haven't found anyone else having this issue. This is kicad 6.0, I will try migrating over to kicad 7.0 to see if it changes anything :)

Edit: Works fine in kicad 7.0, might be a non-issue but will leave it up for anyone still having the issue in kicad 6.0

ianog-eng commented 1 year ago

Also having this issue with KiCad 6.0

bennymeg commented 1 year ago

Probably because of this line: https://github.com/bennymeg/JLC-Plugin-for-KiCad/blob/ef138c8feb8282dfd7ed4f879b4f1364de1db1fd/plugins/process.py#L68 JLC PCB expects this margin. I Checked the API and it seems KiCad excepts an int (here). I haven't encountered this issue before, probably the units KiCad want are not millimeters, I am trying to figure this out.

JHay0112 commented 1 year ago

I have seen this issue in KiCad 6.0 as well. A quick Google says that KiCad internally stores measurements as nanometres (https://docs.kicad.org/6.0/en/pcbnew/pcbnew.html) so perhaps this is what the API is expecting?

bennymeg commented 1 year ago

OK, I'll try to update it to 50000 nanometers.

bennymeg commented 1 year ago

Added a fix in 3.0.2 (prerelease). you can try it manually.

ianog-eng commented 9 months ago

Thank you! Working well in KiCad 7.0