search

bennymeg / Fabrication-Toolkit

An JLC PCB Fabrication Plugin for KiCad
Apache License 2.0
300 stars 52 forks source link

JLCPCB Plugin not running to completion #85

Closed FrankNz closed 1 year ago

FrankNz commented 1 year ago

JLC Plugin Running on Mac. (13.5) The Plugin creates all the files in the temp directory, but, failed when trying to rename the .ZIP file around line 100 in the thread.py file. It seems to construct a new name which would place the renamed file inside a folder that it is in! The rename process wants the renamed file in the same 'location'. I'm telling you nothing new here. I know about '0' Python to be of any help fixing this. Commenting out the 'offending' os.renaming line allows the program to run to completion. The zip file in the production directory has a 'temp' filename.

UPDATE I think the problem is that I had a '/' in the Title of the PCB. Removing the '/' allows your program to run properly!

bennymeg commented 1 year ago

Nice catch, I'll normalize the file name.

FrankNz commented 1 year ago

Hi Benny, Thanks for the quick fix. If I uninstall/install the plugin it will pickup the fix? This will fix the ‘glitch’ for windows users also? Regards Frank

On 18/08/2023, at 11:57 PM, Benny Megidish @.***> wrote:

Nice catch, I'll normalize the file name.

— Reply to this email directly, view it on GitHub https://github.com/bennymeg/JLC-Plugin-for-KiCad/issues/85#issuecomment-1683812325, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTMFCJ27SOOROAF5CPSDELXV5KCZANCNFSM6AAAAAA3VBNYBI. You are receiving this because you authored the thread.

bennymeg commented 1 year ago

No, I need to create a new release first. Then, you will have to install in manually from Github (see Readme.md) because KiCad official repository takes a lot of time to publish a new release.

EDIT: Added a fix in 3.0.2 (prerelease). you can try it manually.

FrankNz commented 1 year ago

Looks good, Thankyou