bennymeg / Fabrication-Toolkit

An JLC PCB Fabrication Plugin for KiCad
Apache License 2.0
300 stars 52 forks source link

output_path characters not normalized #92

Closed Fisheiyy closed 11 months ago

Fisheiyy commented 11 months ago

when exporting files with a odd characters such as ^ it will pass to the name of the output folder and the name of the gerber archive which causes issues when uploading to JLC for production

KiCad 7.0, Plugin 3.0.0

bennymeg commented 11 months ago

This should be handled. Please provide an example.

Fisheiyy commented 11 months ago

This should be handled. Please provide an example.

I havent tested with any other special characters, but the ^ one gets past the current normalization that is happening so it causes an error when uploaded to JLC unless I manually remove the ^ image

bennymeg commented 11 months ago

I just saw you are using v3.0.0 This was fixed at v3.0.2 (currently in prerelease).