bennymeg / nx-electron

Electron schematics for nrwl nx platform
Apache License 2.0
331 stars 85 forks source link

Missing `makerOptionsPath` package option #151

Closed jupapios closed 2 years ago

jupapios commented 2 years ago

Describe the bug

It seems the option to override the maker options was removed, this is commit https://github.com/bennymeg/nx-electron/commit/adb8bb9567fafda4d949d9c588f6c05fc1884d45 that originally added support to that option. It is also listed in the changelog https://github.com/bennymeg/nx-electron/blob/master/CHANGELOG.md#features but when you try to use it it doesn't exist which can be confirmed in the code from master.

To Reproduce

Expected behavior It should use the maker options path you defined

The makerOptionsPath option was supported in pre 12.0.0 versions of nx-electron, I'm using it in a project that uses nx-electron@11.4.1 and it works just as expected, it seems to have been remove in 12.x.x

Desktop (please complete the following information):

bennymeg commented 2 years ago

Thanks for letting me know, I will check it out.