Closed mtrefzer closed 11 months ago
@bennymeg any updates on this? Trying to setup a update server but this is blocking me.
Will be published in the next release.
Any update on this or a workaround? Is it possible to write/update the version in the asar packaged package.json
after make? We are really trying to setup an update server/show accurate versions in our application and this is a blocker.
I was extremely busy in past weeks, so I did not get the chance to publish a new release yet.
As a workaround, you can open the package with 7zip, edit your file and zip it again with asar
.
Released
Describe the bug When I pass a version with
--extraMetadata.version=x.y.z
I expect that this version is used inenvironments
__BUILD_VERSION__
To Reproduce Steps to reproduce the behavior:
package.json
version
to0.0.1
nx run <electron-app-name>:build --extraMetadata.version=0.0.2
nx run <electron-app-name>:make --extraMetadata.version=0.0.2
:build
uses theversion
ofpackage.json
while:make
uses the passedextraMetadata.version
, which leads to inconsistent autoupdates withelectron-updater
Expected behavior
nx run <electron-app-name>:build --extraMetadata.version=0.0.2
should use the passed value instead of the one from package.jsonDesktop:
Additional context
utils/config.ts l.86