NX 17 support - Githubissues

andirsun commented 7 months ago

NX 17 just launched.

V16 of nx-electron is supported ?

lswnsn commented 7 months ago

in my environment, when upgrade nx to 17.1.1, use nx invoke nx-electron:build, there is bellow error:

NX Cannot find module '@nx/workspace/src/utilities/buildable-libs-utils'

Require stack:

/home/shlv/workspace/upgrade/webem/node_modules/nx-electron/src/executors/build/executor.js
/home/shlv/workspace/upgrade/webem/node_modules/nx/src/config/schema-utils.js
/home/shlv/workspace/upgrade/webem/node_modules/nx/src/command-line/run/executor-utils.js
/home/shlv/workspace/upgrade/webem/node_modules/nx/src/command-line/run/run.js
/home/shlv/workspace/upgrade/webem/node_modules/nx/bin/run-executor.js Pass --verbose to see the stacktrace.

so need nx-electron to upgrade to 17 version to support nx-electron build in nx 17 version

bennymeg commented 7 months ago

Not yet.

lswnsn commented 7 months ago

@bennymeg so when nx-electron v17 version can released? thanks.

the0rem commented 7 months ago

@bennymeg I can see this has been marked as completed, but I can't see any PR, commit, or open issue that tracks the NX 17 upgrade?

bennymeg commented 7 months ago

@lswnsn Released in NPM. @the0rem There is v17 branch.

lswnsn commented 7 months ago

@bennymeg thanks

bennymeg / nx-electron