bennymi / ato-ui

The elemental UI component library for Svelte, built with UnoCSS and Melt UI.
https://ato-ui.vercel.app
MIT License
70 stars 4 forks source link

Github linting action / pnpm format #138

Closed delight closed 10 months ago

delight commented 10 months ago
changeset-bot[bot] commented 10 months ago

⚠️ No Changeset found

Latest commit: 8c75349a961de0f40eb42bd7cbce627e4023fada

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ato-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2023 4:04pm
bennymi commented 10 months ago

@delight you were quick on this one haha thanks for the PR, but I'll tackle this one myself later I think😄 I want to revisit all my rules and make sure I see exactly what the linting step does. I'll leave the PR open for now but I might close it later. Hope that's okay for you 😅

delight commented 10 months ago

@delight you were quick on this one haha thanks for the PR, but I'll tackle this one myself later I think😄 I want to revisit all my rules and make sure I see exactly what the linting step does. I'll leave the PR open for now but I might close it later. Hope that's okay for you 😅

I can create a PR with just the gh-lint-action instead ... so that you can use it whenever your linting rules are done

bennymi commented 10 months ago

@delight I added prettier and linting into the workflow in #139 so I'm closing this. Thanks for your PR though :)