search

bennymi / presveltation

PreSveltation: Create fun, interactive, and dynamic presentations and slideshows with Svelte / SvelteKit and Tailwind CSS.
https://presveltation.vercel.app/
MIT License
47 stars 3 forks source link

Mdsvex integrated #16

Closed riziles closed 1 year ago

riziles commented 1 year ago

Added MDsveX, Tailwind Typography, remark-math, rehype-KaTeX and a css file that MDsveX uses for syntax highlighting.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
presveltation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 7:23PM (UTC)
bennymi commented 1 year ago

@riziles thanks for the PR. Just two comments: I think we can remove the svhighlight-code.ts file, that's from the previous slide, and maybe we can also mention MDSveX in the markdown title. Something like this: # We even got Markdown (thanks to [MDSveX](https://mdsvex.pngwn.io/))!

Other than that it looks good. I got some error on Vercel which might be because of an npm install instead of pnpm, but I'm not entirely sure to be honest. See if using pnpm removes it, and I'll have another look at it later.

Edit: Nvm, you were ahead of me. Works now.

riziles commented 1 year ago

D'oh. I spelled pngwn wrong in the commit note.

bennymi commented 1 year ago

Hey @riziles, thanks for making the changes. One more request, can you delete the package-lock.json file as well? It was created by npm. I'll create a contribution guide later that tells people to use pnpm when installing the dependencies. After deleting the file you can mark the PR as ready for review and I'll merge it

bennymi commented 1 year ago

PR relates to #14

riziles commented 1 year ago

Was getting an error message in VS Code (even though everything was building fine):

Cannot find module './Test.md' or its corresponding type declarations

Adding globals.d.ts made it go away. Found the solve here: https://github.com/pngwn/MDsveX/discussions/369