bennypowers / gnome-shell-extension-firefox-pip

Make Firefox Picture-in-Picture window Always on Top
https://extensions.gnome.org/extension/5306/firefox-pip-always-on-top/
GNU General Public License v3.0
9 stars 4 forks source link

The extension doesn't work #6

Closed hachikoharuno closed 10 months ago

hachikoharuno commented 10 months ago

I encountered a problem that the extension does not work because I have a language other than English installed on my system. Based on the fact that the extension worked previously, apparently firefox now localizes the window name (or I don’t know why everything is like this now)

I'm not sure if there is another solution to the problem, but I changed the extension code, simply adding my language (Ru).

export default class FirefoxPIPExtension extends Extension {
  /** @param {Meta.Window} window */
  static isPiP(window) {
    return window.get_title() === 'Picture-in-Picture'
    || window.get_title() === 'Картинка в картинке';
  }
hachikoharuno commented 10 months ago

Yes, now, after the update, everything works well and I am very glad that you have solved the problems globally. Thank you very much.