bennypowers / gnome-shell-extension-firefox-pip

Make Firefox Picture-in-Picture window Always on Top
https://extensions.gnome.org/extension/5306/firefox-pip-always-on-top/
GNU General Public License v3.0
9 stars 3 forks source link

Add prefs for saving or setting window position #8

Open Maickeli opened 4 months ago

Maickeli commented 4 months ago

New try on adding prefs. Didn't get any notification last time the pr was closed or what ever, or I just missed it. Anyway here is about same changes as last time + possibility to save PIP windows position.

I tried to use .ui file like in the extension you mentioned on last pr, but I didn't manage to get it work. "InternalChildren" from the template didn't bind or something. There is a branch on my fork called "ui_test" if you want to take look.

Again default settings keep the same behavior as before, although I would suggest that the "Remember position" would be enabled by default, I think that is default behavior in many environments.

Preferences added: