bennyxguo / Obsidian-Obsidianite

🎨 Obsidian.md custom theme, it's dark and simple but yet still stays sparkles!
MIT License
279 stars 48 forks source link

Code blocks are visually broken in the recent update #21

Open kursorbyte opened 3 years ago

kursorbyte commented 3 years ago

The recent update has made it so some of the code in a code block gets clipped out of the box (for example: >>>). Additonally, when a code block ends, the following line of text doesn't have enough padding and as a result, gets slightly overlapped on the code block box. image

Without theme: image

One more thing: When the fold heading or fold indent option is turned on in editor settings, the clipping stops but the code goes out of the margin on the left. image

This theme is so beautiful, and I personally want to thank you for your hard work :)

bennyxguo commented 3 years ago

Thanks for the support, I will look into this issue. <3

bennyxguo commented 3 years ago

image

For this part I made it so it wont flow out of the code block, but due to the formatting of Codemirror, it gave this type of marking a natural text indentation, It's hard to make it inline of the rest of the line. (Well I gave each line a padding so ... got to find another way to fix this in the future.) For now I will leave it as this for now. @kursorbyte

This fix will be release in the next version, which will be very soon!

image

For this part where the heading goes into the code block, I designed it to be like that, I figure it's natural to leave a new line infront and behind the code block that way this will look natural. like this:

image

kursorbyte commented 3 years ago

@TriDiamond Alright, thank you!