bennyxguo / Obsidian-Obsidianite

🎨 Obsidian.md custom theme, it's dark and simple but yet still stays sparkles!
MIT License
271 stars 47 forks source link

Check box location incorrect if it is in live preview mode and generated by Obsidian tasks plugin #67

Closed nicolelaitc closed 1 year ago

nicolelaitc commented 1 year ago

As title mentioned.

It is fine if I switch to the reading mode or if the tasks are not shown up by the query of this plugin. Fine if I use dataview plugin too. The actually clickable box located somewhere in-between the visual box and tasks.

krokofant commented 1 year ago

@yuiasora1024 Could you provide an example of this? Screenshots and markdown code to replicate the issue.

nicolelaitc commented 1 year ago
螢幕截圖 2022-11-07 上午8 04 45

I actually need to click the space in front of the task to check it off.

krokofant commented 1 year ago

There is a lot weird with the checkboxes in read mode, especially when the lists are indented: image

Maybe the entire read mode code needs to be reviewed, but I don't know why one even uses the read mode after live edit came out. 🤔

nicolelaitc commented 1 year ago

It is not happens in read mode: if I switched to read mode everything is fine.

But if I do it in live preview mode, it becomes weird.

「Emil Sundin @.***>」在 2022年11月7日 週一,上午9:30 寫道:

There is a lot weird with the checkboxes in read mode, especially when the lists are indented: [image: image] https://user-images.githubusercontent.com/5908498/200208289-5807fc55-a123-4fa9-ac2a-1a1a8f5fa13a.png

Maybe the entire read mode code needs to be reviewed, but I don't know why one even uses the read mode after live edit came out. 🤔

— Reply to this email directly, view it on GitHub https://github.com/bennyxguo/Obsidian-Obsidianite/issues/67#issuecomment-1304972136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV6VDEWTQG25UEZ3BYZ7RF3WHBLSVANCNFSM6AAAAAARHDJ6HI . You are receiving this because you were mentioned.Message ID: @.***>

krokofant commented 1 year ago

I can't reproduce this anymore. Now the clickable area around the checkbox is actually larger than the checkbox itself 😅 image