bennyxguo / Obsidian-Obsidianite

🎨 Obsidian.md custom theme, it's dark and simple but yet still stays sparkles!
MIT License
271 stars 47 forks source link

Table border is nearly impossible to see in dark mode #87

Closed fstlaneukraine closed 1 year ago

fstlaneukraine commented 1 year ago

This is actually similar to #48 , but bringing it back up because it's still an issue.

I've tried to create a CSS snippet to take care of this but can't seem to figure out what property to target.

The table border is very dark in dark mode and is almost impossible to see. I'd like to make it white or the color of the headings.

Can this be done?

bennyxguo commented 1 year ago

Hey thanks for raising this ticket. I will look into it.

fstlaneukraine commented 1 year ago

Hey thanks for raising this ticket. I will look into it.

Thank you! I love your theme above all others! New to Obsidian and it helps make it a joy to use.

fstlaneukraine commented 1 year ago

Hello, any update on this?

krokofant commented 1 year ago

Is this better @fstlaneukraine ? Before image

After image

fstlaneukraine commented 1 year ago

Is this better @fstlaneukraine ? Before image

After image

I would be happier with that, yes. I would prefer slightly more but that would be an acceptable minimum if I was allowed to be picky :) .

krokofant commented 1 year ago

I created a PR for Benny to review. If you want to adjust this locally in your CSS snippets you can add the following, and adjust the 0.15 to a higher percentage to make it more visible.

.theme-dark {
  --table-border-color: rgb(14, 210, 247, 0.15);
}
fstlaneukraine commented 1 year ago

I created a PR for Benny to review. If you want to adjust this locally in your CSS snippets you can add the following, and adjust the 0.15 to a higher percentage to make it more visible.

.theme-dark {
  --table-border-color: rgb(14, 210, 247, 0.15);
}

Worked perfectly. Thank you!