bennyxqg / bulk-loader

Automatically exported from code.google.com/p/bulk-loader
0 stars 0 forks source link

Loading starts when "add()" is called. #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi Debert.

Loading starts when "add method" is called because current state and
"IsPaused" are "false". 

I wonder "_ isPaused" property of BulkLoader whether have to be default and
to be "true". 

or

I think that it should be able to specify it by the argument of "Bulkloader
contrutor". 

I'm sorry in sentences not transmitted easily.

I would appreciate it if you could check my opinion.

Original issue reported on code.google.com by yabe0...@gmail.com on 12 Mar 2008 at 4:26

GoogleCodeExporter commented 9 years ago
Hi Yebe.

Just commited this to trunk, _isPaused defaults to true now. Don't seem much 
value,
nor sense to specify that in the constructor.

The loading starts after the "start" method is called, and pause if pauseAll is 
called.

Cheers
Arthur Debert

Original comment by debert on 12 Mar 2008 at 4:40

GoogleCodeExporter commented 9 years ago
Hi Yebe,

Just looking over this, and you are right, loading is starting right away (it 
shouldn't)

I'll commit a fix for it soon.

Thanks
Arthur Debert

Original comment by debert on 12 Mar 2008 at 4:47

GoogleCodeExporter commented 9 years ago
Hi there.

This is fixed as of revision 185. Now the correct behaviour is that a 
BulkLoader will
be stopped until a "start" call is made.

Also added unit tests for this.

Cheers
Arthur

Original comment by debert on 12 Mar 2008 at 5:00

GoogleCodeExporter commented 9 years ago
Hi debert

I confirmed revision 185.
It was not loaded until the start was called. 

Thank you for prompt correspondence.

Original comment by yabe0...@gmail.com on 12 Mar 2008 at 2:47