search

bennyxqg / eaze-tween

Automatically exported from code.google.com/p/eaze-tween
0 stars 0 forks source link

ENTER_FRAME event not unregistered after all tweens have completed #8

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
The 'ticker' object does not unregister itself from ENTER_FRAME events after 
all tweens have 
completed or been destroyed. Optimal behaviour would be to only register for 
ENTER_FRAME 
events when tweens are started, then unregister when they have completed.

Original issue reported on code.google.com by alexande...@gmail.com on 21 Jan 2010 at 8:03

GoogleCodeExporter commented 8 years ago

Original comment by philippe...@gmail.com on 21 Jan 2010 at 8:12

GoogleCodeExporter commented 8 years ago 
I've added test in killTweensOf for any running tweens (went through running 
Dictionary) and if it was empty then removed listener from ticker.

Additionaly in attach I've added test if listner exists and if not I added it.

Original comment by lukasz.g...@gmail.com on 20 Jun 2013 at 12:51

GoogleCodeExporter commented 8 years ago 
Lukasz I don't see any attachment.

Original comment by philippe...@gmail.com on 20 Jun 2013 at 1:25

GoogleCodeExporter commented 8 years ago 
:) I haven't noticed, PFA the modified class now.

Original comment by lukasz.g...@gmail.com on 13 Aug 2013 at 6:03

Attachments:

GoogleCodeExporter commented 8 years ago 
I appreciate your effort, but your suggested fix isn't correct.

Original comment by philippe...@gmail.com on 13 Aug 2013 at 3:10

GoogleCodeExporter commented 8 years ago 
So far it works for me, but If you have a chance to fix it then please do:D

Original comment by lukasz.g...@gmail.com on 14 Aug 2013 at 6:05