search

benoitc / couchbeam

Apache CouchDB client in Erlang
Other
242 stars 114 forks source link

add maps support #133

Open stofel opened 9 years ago

stofel commented 9 years ago

Hi, i add maps support by add couchbeam:open_doc(Db, DocId, Options), Options = [return_maps] Work, but not heavy tested

stofel commented 9 years ago

Add ifdef(MAP_SUPPORT) help to pass the tests? How to be with jsx dependecy which should be updated to version with maps support?

stofel commented 9 years ago

Also need add to documentation: For maps support add to rebar.config {erl_opts, [{d, 'MAPS_SUPPORT'}]}.

benoitc commented 9 years ago

@stofel what do you mean by How to be with jsx dependecy which should be updated to version with maps support? is upgrading the dependency enough?

About tests, they should be upgraded to unit or ct, but waiting that what would be the best way to rerun them <ith maps support? Any idea?

stofel commented 9 years ago

My mistake, jsx is ok. add {erl_opts, [{d, 'MAPS_SUPPORT'}]} to rebar.config get test passed? but its becouse new code not tested :)

benoitc commented 9 years ago

@stofel couchbeam 1.2.1 is released. Tests are now using eunit. It should be feasible to test both by looping over them. Hopefully we can have it in another release this week :)

stofel commented 9 years ago

rebar3 eunit ignore ifdefs. I dont know how to resolve this :(