search

benoitc / couchbeam

Apache CouchDB client in Erlang
Other
242 stars 113 forks source link

Fix calls to nonexistent functions #90

Closed KlausTrainer closed 10 years ago

KlausTrainer commented 10 years ago

Refactorings in the erlang-oauth dependency broke couchbeam_util:oauth_header/3, as the called functions aren't available anymore.

For reference, here the "breaking change" in erlang-oauth:

https://github.com/tim/erlang-oauth/commit/fc5f528cea05b6b0b5e3ace0300268a330b01ac6

benoitc commented 10 years ago

@KlausTrainer is there any oauth release we can rely on ? Maybe we could also just rely on a commit id so couchbeam can resist to the next change?

benoitc commented 10 years ago

Patch looks good for me, I can merge it or let you make the other change to the rebar.config and merge it after, up to you :) Thanks anyway!

KlausTrainer commented 10 years ago

I think that it would generally be a good idea to use tagged versions for dependencies. What do you think?

As I think that this should be addressed separately with regard to all dependencies anyway, feel free to merge this one ;)

benoitc commented 10 years ago

+1