benoitc / couchbeam

Apache CouchDB client in Erlang
Other
242 stars 114 forks source link

Switch deps to use git:// instead of https:// for compatibiity reasons #93

Closed jwilberding closed 10 years ago

jwilberding commented 10 years ago

Using git:// instead of https:// seems to be the more accepted convention and also Heroku is not able to connect to https links when building deployments.

KlausTrainer commented 10 years ago

Using git:// instead of https:// seems to be the more accepted convention and also Heroku is not able to connect to https links when building deployments.

Do you have any substantiation for your statement that "git:// instead of https:// seems to be more accepted convention"?

With the Git Smart HTTP protocol that has been introduced with version 1.6.6, the performance when using HTTP as transport protocol is not significantly worse than compared to using the Git protocol anymore, which means that the only drawback it used to have doesn't exist anymore.

Moreover, using https as transport protocol has the following two advantages:

If "Heroku is not able to connect to https links when building deployments" it means that it is broken and should be fixed. Why don't you just check in the dependencies when doing releases, or create release tarballs that include dependencies as a workaround, rather than trying to force everybody to use an inferior transport protocol.

benoitc commented 10 years ago

@jwilberding any link about this heroku thing?