benoitc / couchbeam

Apache CouchDB client in Erlang
Other
242 stars 113 forks source link

jsx by default? #95

Closed benoitc closed 10 years ago

benoitc commented 10 years ago

Withe the replacement of ibrowse by hackney, I introduced JSX to stream the JSON to replace couchbeam_json_stream. I am currently asking myself if JSX shouldn't be the default in couchbeam, and support jiffy as an option.

The advantages of using a pure Erlang parser would be:

The only disadvantage I see to an erlang solution is that it would be a little slower. On the other hand it will still be possible to compile couchbeam with jiffy as an option.

Thoughts?

dch commented 10 years ago

+1. I think about this as option for couchdb as well for same reason. I suspect that some edge cases with very large JSON docs might perform better under load with a pure erlang version. Would be a good quick thing to do for hackathon.

benoitc commented 10 years ago

@dch applied. thanks for the feedback :)