search

benoitc / couchdbkit

CouchDB python framework
http://couchdbkit.org
Other
265 stars 94 forks source link

Setup file shebang line for python (trivial) #148

Closed crodjer closed 12 years ago

crodjer commented 12 years ago

It is already marked as executable, so the binary should be specified too.

wendall911 commented 12 years ago

setup.py files don't include shebang lines by default. This is intentional, as bin/env might not be the intended interpreter for the environment the installation is targeted at. I'm not sure that this is documented anywhere, but this is certainly intended behavior. Additionally, it's why all instructions read: python setup.py, so you can choose whatever python interpreter that is required.

crodjer commented 12 years ago

Hmm, okay. I started browsing around the source code and found this, figured this might have been accidental. Still, I believe the setup.py shouldn't be marked executable if it doesn't know a default way of execution.

wendall911 commented 12 years ago

Agreed, the executable bit should be dropped. This was likely unintentional.