search

benoitc / dnssd_erlang

Erlang interface to Apple's Bonjour DNS Service Discovery implementation
Apache License 2.0
46 stars 16 forks source link

Add rebar3 support #11

Open surik opened 9 years ago

surik commented 9 years ago

Or maybe I have to use overrides in my application?

andrewtj commented 9 years ago

@benoitc you're not listed as a repo watcher, is this PR on your radar?

benoitc commented 9 years ago

@andrewtj hrm not sure why I was not in the watcher....

Anyway I will look at the PR once I arrive at my desk tonight.

benoitc commented 9 years ago

wez can probably add a Makefile like I did for ucol_nif and then be supported by erlan.mk + rebar2. The question is how to compile under windows that way. Any idea?

surik commented 9 years ago

@benoitc of course, we can add Makefile, but this PR about how to use dnssd_erlang as dependency in rebar3 project.

benoitc commented 9 years ago

@surik yes so let add it :) I was referring to the Makefile in c_src: https://github.com/refuge/ucol_nif/blob/master/c_src/Makefile

Which will build the ports. Then maybe a specific entry for windows can be added there or we keep the escript.