search

benoitc / erlang-idna

Erlang IDNA lib
MIT License
43 stars 29 forks source link

Fixed bug with middle dot context #32

Closed SamuelNichols closed 4 years ago

SamuelNichols commented 4 years ago

erlang sublist takes (list, position, number of characters after)

lists:sublist([1,2,3,4], 2, 2). [2,3] lists:sublist([1,2,3,4], 2, 5). [2,3,4]

previously would only match on l · l and not lists that contained it

benoitc commented 4 years ago

Thanks for the patch :) Can you add a test to reproduce it? would be helpful to make sure no regression happen.

SamuelNichols commented 4 years ago

Thanks for the patch :) Can you add a test to reproduce it? would be helpful to make sure no regression happen.

Not sure if this was what you were asking for but should at least show it's working with "rul·lz" as an example of it working. Can add something else if needed

SamuelNichols commented 4 years ago

Also, looks like Travis failed on one of the versions before it actually hit the test.