search

benoitc / erlang-idna

Erlang IDNA lib
MIT License
43 stars 29 forks source link

Rebarify the erlang-idna #7

Closed wmealing closed 8 years ago

wmealing commented 9 years ago

Move ebin/idna.app to src/ebin/idna.app.src so that rebar clean wont remove a file that wont be rebuilt when the application is recompiled (with rebar).

I noticed you have an packge.exs file in this repository, if this change would break compatibility with elixir build systems I can work around it.

Thanks.

benoitc commented 9 years ago

It would also break simple makefile. Why do you need it by the way? erlang-idna can already be installed using rebar: https://github.com/benoitc/hackney/blob/master/rebar.config#L14

wmealing commented 9 years ago

Why do you need it by the way?

It wasn't the installation that was the problem it was what happens when ebin was cleaned out.

One of the scripts i was using wasn't using rebar clean, it was just rm deps//ebin/\ Of course this trashes this file and it can't be rebuilt when required.

You can close this up if you dont feel the need, i'll just build it from my own repo. Thanks for the fast response time :)

benoitc commented 8 years ago

erlang-idna is compatible with rebar since awhile now, closing this issue then.