benoitc / erlang-nat

implements NAT handling facilities for Erlang applications
Other
57 stars 10 forks source link

Introduce nat_app and use httpc profile #16

Open zp-sd opened 5 years ago

benoitc commented 5 years ago

the patch looks good for me. Let me a few more days to test it though :) I will make a new release before the end of the month anyway.

macpie commented 5 years ago

I need to test this as we are doing some similar stuff in libp2p

benoitc commented 5 years ago

Since the HTTP needs for the request, we can also just replace httpc by a simple TCP connection with HTTP parsing using erlang:decode_packet/3 with a simple connection caching. Thoughts?

macpie commented 5 years ago

I am not sure, I do not really have a preference for this.