search

benoitc / gunicorn

gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.
http://www.gunicorn.org
Other
9.84k stars 1.75k forks source link

Please drop debian/ dir on master #236

Closed lamby closed 13 years ago

lamby commented 13 years ago

Having it on master is rather cumbersome to make the "officlal" Debian packages. Could this be maintained on a separate branch, or dropped entirely?

(Also the official ones are bit more Debian-friendly, so might as well promote the use of them over the debian/ that is shipped in master)

benoitc commented 13 years ago

Why not simply use tags ? About official one why not but it would end up the ppa . Thoughts?

lamby commented 13 years ago

I'm not sure how tags would solve the problem.

Also, I am unclear about what you mean re. the ppa.

benoitc commented 13 years ago

We tag each revision so if the debian package is based on tag it sould works. Aout the pap I mean the "official" gunicorn pap : http://gunicorn.org/install.html#ubuntu-debian

lamby commented 13 years ago

The tags don't help because the tagged trees include your debian/ directory so we are back to where we started.

benoitc commented 13 years ago

mmm ok. I was thinking the debian package could be maintained by the debian packager here or maybe in a general packaging project. Anyway, if we remove it however, we still have the need to provide a package for the people who are using the ppa. or other debian alternatives.

So maybe we could open a gunicorn-packages directory for that ? davisp? tilgovi?

tilgovi commented 13 years ago

@lamby: Are you the debian maintainer? If so, please work with me to make the debian directory work for you. Should I be using the git-buildpackage tools to update the debian folder before every release? What's the best way?

benoitc commented 13 years ago

bump

lamby commented 13 years ago

@tilgovi Yes I am the Debian maintainer.

The best and easiest way to make the debian/ directory work for me is not to include it the upstream master branch. I can work around it, but it isn't very hygienic as SHAs stop matching up etc. It also implies that your debian/ directory is the one being used in Debian, which is not the case.

tilgovi commented 13 years ago

@lamby Yes. That makes sense. But what we're trying to say is that if you'd like you could manage the debian/ directory here so that it is the one being used by Debian. I was asking if it's poor form to have debian/ on master because I know some tools for managing debian packaging with git exist and expect certain branch names by default. I'd like you to advise the best way forward. I'd prefer to have you involved here so that users of deb-based systems don't have to track down the the debian source package to build their own version. It'd be better if the debian/ directory here was just done right. If you think it should be removed from master please advise with a branch name where I can place commits to add the debian/ directory and then you can submit pull requests against that if there are changes needed.

Does that make sense or am I crazy?

tilgovi commented 13 years ago

It seems best to me to have debian/ here as long as it's correct. From my little experience with git-buildpackage, for instance, I know that it's set up well to maintain debian packaging of upstream projects that do not include debian/. In our case, consider it like there is no upstream and there is only debian, which should be fine if we can get the packaging right. No?

adamn commented 13 years ago

@tilgovi I think it's probably sensible to just follow @lamby on this since he's the Debian maintainer. Most projects don't have a debian config once there's something supported on the Debian side.

benoitc commented 13 years ago

I propose to drop it from the repo and eventually having a gunicorn-packaging for our needs if it's still needed. @lamby what would be the best way to still continue to push to the ppa using official package? Is tere any easy way to do it ? ppa is used around by people who want to have daily packages. Let me know.

lamby commented 13 years ago

Just to be clear, I can work around you guys having your own debian/ but it causes some issues in that the tarball hashes don't match up and that you don't get some rather nice-to-have integration stuff, so it's difficult to recommend them for production usage.

(I uploaded gunicorn to the official backports repositories, so that should limit the need for these snapshot .debs anyway..)

@benoitc I'm afraid I know absolutely nothing about the PPA system. :(

tilgovi commented 13 years ago

Okay. Let's drop the debian/ dir. @lamby please link me to your debian source package so I can make sure it gets put into a ubuntu ppa since there's bound to be lots of consumption from there. Maybe we can create a page on gunicorn.org to aggregate some of the community build distributions.

lamby commented 13 years ago

@tilgovi The most recent source package I uploaded is http://ftp.de.debian.org/debian/pool/main/g/gunicorn/gunicorn_0.13.1-1.dsc and that was built from https://github.com/lamby/pkg-gunicorn using git-buildpackage & pristine-tar. Does that help? :)

Oh, I'd love a page on gunicorn.org for this sort of thing, or at least a Debian section on http://gunicorn.org/install.html

jbergstroem commented 13 years ago

Contributing to "install.rst" :-)

Installing on gentoo: emerge gunicorn

lamby commented 13 years ago

@jbergstroem Tssch, fine! https://github.com/benoitc/gunicorn/pull/248 Now where's your pull request? :p