search

benoitc / gunicorn

gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.
http://www.gunicorn.org
Other
9.65k stars 1.74k forks source link

Web site build accidentally included in pypi releases #3109

Open tsaarni opened 7 months ago

tsaarni commented 7 months ago

Request: remove the docs/build directory from future pypi releases.

Background:

Recent pypi release packages contain the full web site docs in docs/build/ directory, while the older releases only contained the placeholder files e.g. docs/site/install.html which redirects to https://gunicorn.org/.

For example, see 21.2.0 release here.

The website files can mistakenly cause gunicorn to be flagged to contain GPL license by license scanners. The files docs/build/html/_static/js/html5shiv.min.js and docs/build/html/_static/js/html5shiv-printshiv.min.js in the release package, coming via Read the Docs theme, have GPL2 license text (link). However, this is false flag: even when considering these are now part of gunicorn release, it is clarified here in html5shiv project, that those files are dual-licensed and user is free to pick MIT over GPL2.

benoitc commented 7 months ago

hrm odd I will fix it. thanks for the notice

pajod commented 1 month ago

As a minimal fix for excluding generated html duplicates (and bundled _static that comes with those) from sdist, appending recursive-exclude docs/build * to MANIFEST.in seems reasonable.