This does not fix any bug, nor does it add any feature.
But if my less obviously correct patch for #3125 that deletes all the duplicate branches in error handling is flawed, then adding this assertion should reduce the impact of bugs from somewhat worrying "reflected injection" to much less worrying "crashes with proper traceback".
EDIT: No, those are not superfluous-parens. (Using the binding precedence of not) is not producing readable code. I recommend disabling that pylint warning
Suggested merge order: first #3110 - then this one
This does not fix any bug, nor does it add any feature.
But if my less obviously correct patch for #3125 that deletes all the duplicate branches in error handling is flawed, then adding this assertion should reduce the impact of bugs from somewhat worrying "reflected injection" to much less worrying "crashes with proper traceback".
EDIT: No, those are not
superfluous-parens
. (Using the binding precedence ofnot
)is not
producing readable code. I recommend disabling that pylint warning