benoitc / gunicorn

gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.
http://www.gunicorn.org
Other
9.77k stars 1.75k forks source link

packaging: include tox.ini in source distribution (sdist) #3269

Closed pajod closed 1 month ago

pajod commented 1 month ago

Argument from authority: See what setuptools does & documents: https://github.com/pypa/setuptools/blob/1d2fd37368fc2381e21cd5466aeb222fc11db2db/MANIFEST.in

Confirmation:

$ python -m build
$ tar -tf dist/gunicorn-*.tar.gz | grep tox
gunicorn-23.0.0/tox.ini
jayaddison commented 1 month ago

@pajod why should tox.ini be included in a distributable? Naively I would assume that a distributable release includes only the application code -- that is, the code necessary to run a project on a production system.

jayaddison commented 1 month ago

Sorry! This is an sdist -- a source distributable. And those can include test code. In that case it seems more reasonable to include tox.ini.